javascript - Node.js and asynchronous programming with Q -

-

is following correct way go things? sign controller action. im creating user , group add user to. notice have method level variables called user , group. rest of code asynchronous using q module.

is ok have method level variables or overriden person signing @ same time?

exports.postsignup = function(req, res, next) {      var user,         group;      return q.invoke(exports, 'parseuser', req, null)         .then(function(u)         {             user = u;             return q.invoke(exports, 'postcreateuser', user).fail(function(err) { throw err; });         })         .then(function()         {             group = new group();             group.userids = [user._id];             return q.invoke(exports, 'postcreategroup', group).fail(function(err) { throw err; });         })         .then(function()         {             user.groupid = group._id;             group.userids = [ user._id ];         })         .then(function()         {             return q.ninvoke(req, 'login', user).fail(function(err) { throw err; });         })         .then(function()         {             return res.redirect('/tour');         })         .fail(function (err)         {             console.log('u:' + user);             console.log('g:' + group);             return exports.createvalidationerror(error, req, res, user);         }); };

is ok have method level variables or overriden person signing @ same time?

no, won't locally scoped postsignup function.

it little ugly, nesting them might better choice here:

exports.postsignup = function(req, res, next) {     return q.invoke(exports, 'parseuser', req, null).then(function(user) {         return q.invoke(exports, 'postcreateuser', user).then(function(createduser) {             var group = new group();             group.userids = [user._id];             return q.invoke(exports, 'postcreategroup', group).then(function(createdgroup) {                 user.groupid = group._id;                 group.userids = [ user._id ]; // repeat this?                  return q.ninvoke(req, 'login', user)             }).then(function(loggedinuser) {                 return res.redirect('/tour');             }).fail(function(err) {                console.log('g:' + group);                throw err;             });         }).fail(function(err) {             console.log('u:' + user);             return exports.createvalidationerror(error, req, res, user);         });     }) // .fail(function(err) {        //     … // parseuser or createvalidationerror failed        // }); };

do need break down different steps different functions or can have 1 async function?

you have 1 async function currently, might want break down creating user new group, , logging him in plus redirecting him /tour.


Comments

Post a Comment

Popular posts from this blog

php - Magento - Deleted Base url key -

-
i working on cleaning url: http://mydomain.com/shop/shop/deals i going through settings in configuration tab in admin panel on magento , change secure , unsecure base urls remove first base url "shop" web page read: http://mydomain.com/shop/deals so changed unsecure base urls mydomain.com/shop mydomain.com , secure 12.345.67.89/shop 12.345.67.89. wrong thing do. i cannot reload page or admin console. how access these files through ftp , change correctly there?? when make changes in admin panel changes made in database not in file. have make changes in database. 1.go database , select core_config_data table under table find web/unsecure/base_url , web/secure/base_url . make changes here. don't forget clear cache in var/cache folder
Read more

javascript - Tooltipster plugin not firing jquery function when button or any click even occur -

-
i want use tooltipster plugin click element in body show tooltip , want have close button inside tooltip close it. however use jquery click() function handle won't fired. tried solution in post. worked when tooltip triggered hover event. tooltipster plugin not firing jquery function when link in in tooltip clicked the original solution using hover in jsfiddle trigger: 'hover', instead using click show tooltip trigger: 'click', http://jsfiddle.net/bcqyl/7/ it won't fire click event in jquery block. can captured normal javascript function only. checked should code in tooltipster plugin locked , captured "click()" event inside tips when in click trigger mode. i tried other event onchange event of radio button fired when using code in original solution @evan right. tooltip doesn't exist in dom , can't bind/delegate action (even if go way $(document) after domready). if you're after close button inside of too...
Read more

java - WrongTypeOfReturnValue exception thrown when unit testing using mockito -

-
my test list<person> mylist; @test public void testisvalidperson() { mylist = new arraylist<person>(); mylist.add(new person("tom")); when(persondao.get(person)).thenreturn(mylist); when((persondao.get(person)).isempty()).thenreturn(false);//------exception thrown boolean result = service.isvalid("tom"); assertfalse(result); } method tested: public boolean isvalid(string person){ persondao = new persondao(); person personobj = new person(person); return (persondao.get(person).isempty())?false : true; } exception thrown: org.mockito.exceptions.misusing.wrongtypeofreturnvalue: boolean cannot returned get() get() should return list *** if you're unsure why you're getting above error read on. due nature of syntax above problem might occur because: 1. exception *might* occur in wrongly written multi-threaded tests. please refer mockito faq on limitations of concurrency testing. 2. sp...
Read more